Re: WEAK_REFERENCE?

From: Konstantin Belousov <kostikbel_at_gmail.com>
Date: Mon, 11 Nov 2013 09:47:06 +0200
On Sat, Nov 09, 2013 at 11:16:08PM +0100, Andreas Tobler wrote:
> Hi all,
> 
> anyone interested in this patch to remove the WEAK_ALIAS and introduce
> the WEAK_REFERENCE?
> 
> http://people.freebsd.org/~andreast/weak_ref.amd64.diff
> 
> I have this running since months on amd64 and I have no issues with.
> 
> I remember having had a communication with bde_at_ that he is in favour in
> doing that but I lacked the time to complete.
> A similar thing is pending for i386 and sparc64. The ppc stuff is
> already committed since a longer time.
> 
> If no one is interested, I'm happy to clean up my tree and skip this.

I am not sure why do you include the changes to END() in the same patch.
Did you looked over the all END() usages on amd64, is it always paired
with ENTRY() ?  The CNAME() for ELF is the pedantism anyway.

Other than the somewhat questionable inclusion of the END() change, which
should be committed separately, if ever, I think the change is fine.

Received on Mon Nov 11 2013 - 06:47:16 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:44 UTC