Re: extattr_set_*() return type

From: <mdf_at_FreeBSD.org>
Date: Tue, 20 Dec 2011 14:18:58 -0800
On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin <jhb_at_freebsd.org> wrote:
> Hmm, if these functions are expected to operate like 'write(2)' and are
> supposed to return the number of bytes written, shouldn't their return value
> be 'ssize_t' instead of 'int'?  It looks like the system calls themselves
> already do the right thing in setting td_retval[] (they assign a ssize_t to it
> and td_retval[0] can hold a ssize_t on all of our current platforms).  It
> would seem that the only change would be to the header and probably
> syscalls.master.  I guess this would require a symver bump to fix though.

An extended attribute larger than 2GB is a programming abuse, though.
Technically int may not be 32 bits but it is on all supported
platforms now.

Cheers,
matthew
Received on Tue Dec 20 2011 - 21:44:58 UTC

This archive was generated by hypermail 2.4.0 : Wed May 19 2021 - 11:40:22 UTC